Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image sub-query #6

Merged
merged 2 commits into from
Jan 3, 2014
Merged

Fix image sub-query #6

merged 2 commits into from
Jan 3, 2014

Conversation

larrylv
Copy link
Collaborator

@larrylv larrylv commented Jan 3, 2014

As I said in #5.

Arizona Diamondbacks doesn't have /common/topic/image value, so it was filtered out. We should set an optional flag on that sub-query to make sure it doesn't filter out results.

And cached teams.json was generated with the rake task, no modifications.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 14c8d41 on larrylv:fix-image-sub-query into b28a76b on sferik:master.

sferik added a commit that referenced this pull request Jan 3, 2014
@sferik sferik merged commit 1070099 into sferik:master Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants