Apply fixes from StyleCI #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfneal
added a commit
that referenced
this pull request
Sep 9, 2021
* MAKE `Url` & `ImgShieldsUrl` utility classes for generating urls & svgs REFACTOR `DependencyUrl` to provide both urls & svgs rather than using separate classes with inheritance. CUT `DependencySvgTest` and moved methods to `DependencyUrlTest`. * Apply fixes from StyleCI (#55) * ADD ability to pass global img shields params to `DependencyRepository` & `DependencyService` * Apply fixes from StyleCI (#56) * REFACTOR setting of `DependenciesRepository::$imgShieldGlobalParams` property by adding setter method * Apply fixes from StyleCI (#57) * FIX issue with `ImgShieldsUrl::withGlobalParams()` method trying to merge null array * ADD testing of adding global params to img shield URLs * Apply fixes from StyleCI (#58)
sfneal
added a commit
that referenced
this pull request
Sep 9, 2021
* URL params & Img Shield global params (#59) * MAKE `Url` & `ImgShieldsUrl` utility classes for generating urls & svgs REFACTOR `DependencyUrl` to provide both urls & svgs rather than using separate classes with inheritance. CUT `DependencySvgTest` and moved methods to `DependencyUrlTest`. * Apply fixes from StyleCI (#55) * ADD ability to pass global img shields params to `DependencyRepository` & `DependencyService` * Apply fixes from StyleCI (#56) * REFACTOR setting of `DependenciesRepository::$imgShieldGlobalParams` property by adding setter method * Apply fixes from StyleCI (#57) * FIX issue with `ImgShieldsUrl::withGlobalParams()` method trying to merge null array * ADD testing of adding global params to img shield URLs * Apply fixes from StyleCI (#58) * BUMP CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies code style fixes from an analysis carried out by StyleCI.
For more information, click here.