Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bigquery job location in parameters while getting job details #346

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

phanindra-ramesh
Copy link
Contributor

No description provided.

@wangxiaoying
Copy link
Contributor

Hi @phanindra-ramesh , thank you so much for the PR! Other than the bigquery/mod.rs file, we also issue query to bigquery to get some metadata from it here. Do you think this part should also add the location?

@phanindra-ramesh
Copy link
Contributor Author

hi @wangxiaoying , adding location in the QueryRequest is not required here the specified code snippet makes a call to bigquery API to get the query resultset where as, the code where I made changes requests for the result set for the job that was already submitted in the previous step.

@wangxiaoying wangxiaoying merged commit 87ffcc3 into sfu-db:main Sep 7, 2022
@wangxiaoying
Copy link
Contributor

Hi @phanindra-ramesh , got it. I have merged the code and released an alpha version for this feature. Can you try pip install connectorx==0.3.1a6 to test whether it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants