Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information obscured on some pages #99

Closed
ccolliga opened this issue Feb 17, 2021 · 2 comments
Closed

Information obscured on some pages #99

ccolliga opened this issue Feb 17, 2021 · 2 comments
Assignees

Comments

@ccolliga
Copy link
Collaborator

Describe the bug
I just noticed that the number count is obscured in some of the boxes on this page, and perhaps others like it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...' Reports
  2. Click on '....' Sources
  3. Scroll down to '....' First box under institutions, for example
  4. See error

Expected behavior
I expect to see the number count on the page.

Screenshots
If applicable, add screenshots to help explain your problem.
Capture d’écran, le 2021-02-16 à 20 32 42

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS Mojave
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@joeytakeda
Copy link
Contributor

Since there are a number of lengths that the titles that those boxes can be (i.e. "READEX" vs "Archives Départementales ..."), my suggestion is that we simply fix the height of the heading to two lines of text. If the heading exceeds that, then it truncates it with ellipses.

The other advantage to this approach is that the text in the boxes line up nicely, so the numbers and the headings are always in a consistent place:

Screen Shot 2021-02-17 at 10 37 16 AM

This change would apply everywhere, though, so you'd get the same behaviour in the grid of newspapers. There are only a handle of newspapers that have titles that exceed 2 lines, but if that's an issue, we could set the limit to three lines of text. That would mean fewer ellipses in the headings, but we'd have to increase the tile's height a bit.

What do you think?

@ccolliga
Copy link
Collaborator Author

ccolliga commented Feb 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants