Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ; as classpath separator on Windows #68

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 29, 2023

Fix for this error seen in CI:

Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 77: bazel-out/x64_windows-fastbuild/bin/src/main/protobuf/libdeps_proto-speed.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/libcore.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/liblite_runtime_only.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/guava/31.1-jre/guava-31.1-jre.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_annotations/2.20.0/processed_error_prone_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_type_annotations/2.20.0/processed_error_prone_type_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/github/stephenc/jcip/jcip-annotations/1.0-1/processed_jcip-annotations-1.0-1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/code/findbugs/jsr305/3.0.2/processed_jsr305-3.0.2.jar:third_party/turbine/turbine_direct.jar
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at java.base@20.0.2/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
	at java.base@20.0.2/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232)
	at java.base@20.0.2/java.nio.file.Path.of(Path.java:148)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.expandAsteriskClassPathElement(NativeImage.java:1795)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.addCustomImageClasspath(NativeImage.java:1774)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.processClasspathArgs(DefaultOptionHandler.java:435)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.consume(DefaultOptionHandler.java:72)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage$NativeImageArgsProcessor.apply(NativeImage.java:1703)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.processNativeImageArgs(NativeImage.java:2016)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.completeImageBuild(NativeImage.java:945)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.build(NativeImage.java:1592)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1557)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.main(NativeImage.java:1531)

Speculative fix for this error seen in CI:
```
Exception in thread "main" java.nio.file.InvalidPathException: Illegal char <:> at index 77: bazel-out/x64_windows-fastbuild/bin/src/main/protobuf/libdeps_proto-speed.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/libcore.jar:bazel-out/x64_windows-fastbuild/bin/external/com_google_protobuf/java/core/liblite_runtime_only.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/guava/31.1-jre/guava-31.1-jre.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_annotations/2.20.0/processed_error_prone_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/errorprone/error_prone_type_annotations/2.20.0/processed_error_prone_type_annotations-2.20.0.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/github/stephenc/jcip/jcip-annotations/1.0-1/processed_jcip-annotations-1.0-1.jar:bazel-out/x64_windows-fastbuild/bin/external/maven/com/google/code/findbugs/jsr305/3.0.2/processed_jsr305-3.0.2.jar:third_party/turbine/turbine_direct.jar
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
	at java.base@20.0.2/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at java.base@20.0.2/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
	at java.base@20.0.2/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232)
	at java.base@20.0.2/java.nio.file.Path.of(Path.java:148)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.expandAsteriskClassPathElement(NativeImage.java:1795)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.addCustomImageClasspath(NativeImage.java:1774)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.processClasspathArgs(DefaultOptionHandler.java:435)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.DefaultOptionHandler.consume(DefaultOptionHandler.java:72)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage$NativeImageArgsProcessor.apply(NativeImage.java:1703)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.processNativeImageArgs(NativeImage.java:2016)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.completeImageBuild(NativeImage.java:945)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.build(NativeImage.java:1592)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1557)
	at org.graalvm.nativeimage.driver/com.oracle.svm.driver.NativeImage.main(NativeImage.java:1531)
```
@fmeum fmeum requested a review from sgammon as a code owner August 29, 2023 19:59
@sgammon
Copy link
Owner

sgammon commented Aug 29, 2023

@fmeum thanks for the contribution, i'll force push a commit with a signature and to fix commitcheck (this project uses conventional commits, but it's mostly cosmetic).

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon
Copy link
Owner

sgammon commented Aug 29, 2023

@fmeum nevermind, forgot i can't push to your fork. I'm okay with foregoing the signature on this one. Thanks again. Will get back to you about BCR.

@sgammon sgammon merged commit 2996427 into sgammon:main Aug 29, 2023
41 checks passed
@fmeum fmeum deleted the windows-classpath-separator branch August 29, 2023 20:48
@sgammon sgammon mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants