Add support for setting UID/GID through mount options #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with read-only support, it may be useful to set the filesystem default UID/GID to an arbitrary value. With this patch, the user can use the "uid=N", "gid=N", "user_id=N" or "group_id=N" options to set the user and group IDs for the whole filesystem. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
|
Merged master to solve conflicts, feel free to let me know if you have any comments regarding this PR. |
lionello
reviewed
Oct 3, 2021
| st.st_uid = geteuid(); | ||
| st.st_gid = getegid(); | ||
| st.st_uid = g_uid; | ||
| st.st_uid = g_gid; |
There was a problem hiding this comment.
That can't be right. Did you mean to set st.st_gid?
|
The PR seems already merged with commit d9ae52c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The use-case is the following one:
Setting UID/GID for the whole APFS filesystem enables regular users writing to the overlayfs.
This patch solves issue #61