Add new toggleable options #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options The commit refactors the script generation process in the `generate_scripts.py` file by adding the ability to hide certain options and checking for incompatible option combinations. The changes ensure that the generated scripts accurately represent the selected options, improve code organization, and prevent the execution of invalid configurations. The modifications also include the handling of custom generation strategies and the addition of existing data to the `AxClient` in `main.py.jinja`. This enhances the flexibility of the script generation process and allows for more advanced experimentation. No issues are referenced in this commit. Note: The subject line should be modified as necessary to accurately reflect the main purpose of the changes within 50 characters.
Refactor script generation process in 'generate_scripts.py' to incorporate options specific to the FULLYBAYESIAN model, such as 'num_samples' and 'warmup_steps'. These options are now passed as arguments to the template, resulting in more accurate and efficient testing. Additionally, the script now generates test files in separate directories, improving code organization. This enhancement will facilitate faster debugging and testing of the FULLYBAYESIAN model. No issue references.
I think due to an issue with using multiple True False values, and then the strikethrough text not working properly when switching back and forth.
For SAASBO specifically
reminded me of the need for batch optimization
Still requires troubleshooting of the strikethrough behavior
Closed
|
@hiirrxnn, I'm also curious to get your thoughts on the new options I'm implementing in the dev branch. See https://honegumi.readthedocs.io/en/dev/ for the |
|
Have you merged the changes of branch dev to the current working version ? |
|
@hiirrxnn sorry, I meant to say that's the link to the |
…e__use_existing_data-False__use_constraint-True__use_categorical-True__use_custom_threshold-False.py
The undefined was because it was searching for a deviating option when it was comparing the same config, which threw an error when trying to use an index on something empty/undefined. closes #19
The number of them is getting unwieldy
This was
linked to
issues
Feb 9, 2024
Mostly to get tests passing so I can merge into main
|
Hi @hiirrxnn, sorry for the delay. Going to merge now - had several features that I was still debugging, but to make sure I can get some of the ones I've implemented, I've temporarily disabled a few of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-objective, high-dimensional, constrained, mixed variable (numeric+categorical), and incorporating domain knowledge (so far).
Also need to address: