This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Build self-contained docker image including all shell scripts #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmariofredo
force-pushed
the
master
branch
from
798e4c6
to
31196c7
Compare
sgielen
reviewed
Oct 10, 2020
|
|
||
| ``` | ||
| docker run -e TARGET=all -v ${PWD}:/app -v /dev:/dev --privileged picl-builder:latest | ||
| docker run -e TARGET=raspberrypi -v $PWD/config:/app/config -v $PWD/deps:/app/deps -v $PWD/out:/app/out -v /dev:/dev --privileged elmariofredo/picl-k3os-image-generator:v0.2 |
There was a problem hiding this comment.
I would suggest to either keep the docker build here, or perhaps we can set up GitHub actions on this repo to build & publish this image automatically?
There was a problem hiding this comment.
(I personally don't like running personally-built images from Docker Hub since you can't be sure that nothing evil happened up inside the image...)
|
Thanks @elmariofredo! I like the idea, but would like to auto-build the images from this repository if you agree with that. Also, even if the image is built automatically, I'd also like to keep the build instructions in README to allow users the ability to build the image themselves if they want to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By building docker image with scripts baked in users don't have to clone this repo and just run docker image.