Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook progress support #34

Open
jeromekelleher opened this issue Feb 23, 2024 · 4 comments
Open

Notebook progress support #34

jeromekelleher opened this issue Feb 23, 2024 · 4 comments

Comments

@jeromekelleher
Copy link
Contributor

Should be as simple as

from tqdm.auto import tqdm

Will need to check how well it works across both.

Should wait until we've abstracted out the "scan" bit to use the standard parallel worker pattern

@tomwhite
Copy link
Contributor

tomwhite commented Mar 4, 2024

Just wanted to say I've been using Rich progress bars recently in another project, which I've found to be easier to work with than tqdm.

@jeromekelleher
Copy link
Contributor Author

I've been wanting to play with Rich for a while, could be fun. Looks like the dependencies aren't too bad

I'd be open to switching to Rich if it gives us an overall nicer experience on the CLI

@tomwhite
Copy link
Contributor

tomwhite commented Mar 4, 2024

It looks nicer too I think. BTW pip uses Rich for its progress bars.

@jeromekelleher
Copy link
Contributor Author

I had a play in #64 and it is very nice @tomwhite. Unfortunately it doesn't work as well as tqdm for our usage - I opened issue #65 to note the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants