Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merge parameter to method functions #250

Merged
merged 7 commits into from
Sep 14, 2020
Merged

Add merge parameter to method functions #250

merged 7 commits into from
Sep 14, 2020

Conversation

tomwhite
Copy link
Collaborator

Fixes #103

jeromekelleher
jeromekelleher approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

sgkit/stats/association.py Outdated Show resolved Hide resolved
sgkit/stats/hwe.py Show resolved Hide resolved
@jeromekelleher
Copy link
Collaborator

LGTM - @eric-czech, @ravwojdyla, it'd be good to get your eyes on this before we start duplicating the pattern.

eric-czech
eric-czech approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@eric-czech eric-czech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ravwojdyla
ravwojdyla requested changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@ravwojdyla ravwojdyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomwhite could you please also update pc_relate?

@ravwojdyla
Copy link
Collaborator

@tomwhite thanks, pc_relate still has the old docstring, could you please update that as well?

@tomwhite
Copy link
Collaborator Author

Oops - should be fixed now.

@jeromekelleher jeromekelleher added the auto-merge Auto merge label for mergify test flight label Sep 14, 2020
@mergify mergify bot merged commit b4b57bc into sgkit-dev:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravwojdyla ravwojdyla ravwojdyla approved these changes

@jeromekelleher jeromekelleher jeromekelleher approved these changes

@eric-czech eric-czech eric-czech approved these changes

Assignees
No one assigned
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Append output variables from functions to input dataset
4 participants
@tomwhite @jeromekelleher @ravwojdyla @eric-czech