Save memory from interleaved attention #1151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
Ying1123
changed the title
Ying1123
force-pushed
the
ying-window-save-mem
branch
2 times, most recently
from
feda9b9
to
1404d94
Compare
Ying1123
force-pushed
the
ying-window-save-mem
branch
4 times, most recently
from
bc787b2
to
2d440b3
Compare
Ying1123
force-pushed
the
ying-window-save-mem
branch
from
2d440b3
to
ebed4f0
Compare
|
Is interleaved attention the gemma-2 style attention (one layer full-attention followed by another layer of sliding window attention)? |
|
@yzh119 Yes, this is for gemma |
|
Close it for now. It should come up after the memory pool refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.