Skip to content

Docker #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2016
Merged

Docker #20

merged 10 commits into from
Jun 4, 2016

Conversation

tmerlier
Copy link
Contributor

@tmerlier tmerlier commented Jun 3, 2016

Réf #8

@tmerlier tmerlier added the code label Jun 3, 2016
@tmerlier tmerlier self-assigned this Jun 3, 2016
jdesboeufs
jdesboeufs reviewed Jun 3, 2016
View reviewed changes
Dockerfile Outdated
# Install app dependencies
COPY . /usr/src/api-communes
RUN npm install
RUN npm run postinstall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas utile, le postinstall est appelé automatiquement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il semblerait que non. Ce mystère reste à élucider.

@jdesboeufs
Copy link
Contributor

Et sinon il manquera une mise à jour du README ;)

@ThibautGery
Copy link

J'ajouterai un docker-compose.yml afin de tout lancer avec la commande docker-compose up

@jdesboeufs
Copy link
Contributor

Thx.
De mon côté j'ai encore des problèmes de postinstall :(
Faut qu'on voit ça avec @ThibautGery la semaine prochaine.

@ThibautGery
Copy link

Je suis pas là Lundi et Mardi mais avec plaisir (il faut aussi ajouter le
fichier package.json faire npm install puis ajouter le reste des sources,
ça améliore la vitesse du build)

Thibaut Géry

2016-06-04 14:11 GMT+02:00 Jérôme Desboeufs notifications@github.com:

Thx.
De mon côté j'ai encore des problèmes de postinstall :(
Faut qu'on voit ça avec @ThibautGery https://github.com/ThibautGery la
semaine prochaine.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFlwwb_n5QhrglpCHC7qsFQhPSX42lWkks5qIWttgaJpZM4ItbCm
.

ThibautGery
ThibautGery reviewed Jun 4, 2016
View reviewed changes
docker-compose.yml Outdated
@@ -0,0 +1,5 @@
services:
build: .
dockerfile: Dockerfile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instruction qui n'est pas nécessaire

@jdesboeufs
Copy link
Contributor

Ça me parait bon maintenant ;)

@jdesboeufs jdesboeufs merged commit a9d00f2 into master Jun 4, 2016
@jdesboeufs jdesboeufs deleted the docker branch June 4, 2016 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tmerlier tmerlier

Labels

code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmerlier @jdesboeufs @ThibautGery