Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modify whiskers mode for dataset #88

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Allow modify whiskers mode for dataset #88

merged 2 commits into from
Oct 19, 2023

Conversation

abm0
Copy link

@abm0 abm0 commented Oct 16, 2023

No description provided.

@abm0 abm0 force-pushed the allow-modify-whiskers-config branch from 4086bbb to d9f6220 Compare October 16, 2023 15:20
@abm0
Copy link
Author

abm0 commented Oct 16, 2023

Hey @sgratzl!
Default 'nearest' whiskers mode config was not working for my data as expecting, making max whisker value lower than q3 value, so I've decided to allow it's configuration for datasets. What do you think? Please review.

@sgratzl sgratzl added the enhancement New feature or request label Oct 16, 2023
@sgratzl sgratzl self-assigned this Oct 16, 2023
sgratzl
sgratzl requested changes Oct 18, 2023
View reviewed changes
src/data.ts Show resolved Hide resolved
@sgratzl sgratzl changed the base branch from main to dev October 19, 2023 12:01
sgratzl
sgratzl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good thx

@sgratzl sgratzl merged commit 174d36a into sgratzl:dev Oct 19, 2023
@abm0
Copy link
Author

abm0 commented Oct 19, 2023 •
edited
Loading

Thanks! Could you please make a release with this change? @sgratzl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratzl sgratzl sgratzl approved these changes

Assignees

@sgratzl sgratzl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abm0 @sgratzl