Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capistrano 3 #21

Closed
mdpatrick opened this issue Dec 1, 2013 · 14 comments
Closed

Add support for capistrano 3 #21

mdpatrick opened this issue Dec 1, 2013 · 14 comments

Comments

@mdpatrick
Copy link
Contributor

Capistrano 2 is now considered 'legacy' and is tagged as such on the capistrano repo.

@dmitry
Copy link

dmitry commented Dec 19, 2013

Please add support.

@sauliusgrigaitis
Copy link
Contributor

Check my fork sauliusgrigaitis/capistrano-db-tasks@1c5f0ef for Capistrano 3 support.

@dmitry
Copy link

dmitry commented Feb 8, 2014

Can you do a pull-request?

@sauliusgrigaitis
Copy link
Contributor

It's not backward compatible with Capistrano 2, merging back would make legacy users unhappy.

@dmitry
Copy link

dmitry commented Feb 8, 2014

What about moving those changed into a new branch with a new major version? Or you can change s.add_development_dependency "capistrano", "> 2.0.0" to s.add_development_dependency "capistrano", "~> 3.0"?

@sauliusgrigaitis
Copy link
Contributor

I believe best way would be to support both v2 and v3. Frankly, original code is very coupled, I don't see easy and nice way how to make support for v2 and v3. Maybe somebody has an ideas and time to make it.

@sgruhier
Copy link
Owner

sgruhier commented Feb 8, 2014

I think may be the best is to make a cap2.0 branch and to release this version (0.3?)
Then merge @sauliusgrigaitis Capistrano 3 support to master (and may be release it as 0.4)
Any other ideas?

@sgruhier
Copy link
Owner

sgruhier commented Feb 8, 2014

legacy users should use rubygems.org and not github/master

@dmitry
Copy link

dmitry commented Feb 8, 2014

I agree with @sgruhier. Legacy users will use rubygems. If they will do bundle update, then the add_dependency with the new version will prevent gem from updates. Code for capistrano 3.0 should be in master branch, and legacy code in branch something like v0.3.

@sauliusgrigaitis
Copy link
Contributor

Sounds like a plan. I can make pull request if no one has more ideas.

@sgruhier
Copy link
Owner

sgruhier commented Feb 8, 2014

you already made a PR no?
It's late now for me (in France), I have to go.
I'll look at it tomorrow and do it. In the mean time, you have any idea, new PR or anything that can help, I'll really appreciate.
Thanks for the cap v3 support!!

@dmitry
Copy link

dmitry commented Feb 8, 2014

Thanks for the support.

@sauliusgrigaitis
Copy link
Contributor

It's my pleasure to contribute!

@sgruhier
Copy link
Owner

sgruhier commented Feb 9, 2014

Big thanks to @sauliusgrigaitis

@sgruhier sgruhier closed this as completed Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants