Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.5-1.21 #912

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Aurelien30000
Copy link
Contributor

@Aurelien30000 Aurelien30000 commented Jul 7, 2024

  • Update maven plugins dependencies
  • Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping

You can try it with the following provided .jar.
Please be cautions using it!

1.21.1 supported

NametagEdit.zip

- Update maven plugins dependencies
- Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping
@fleivinho
Copy link

Nice!

@riqvip
Copy link

riqvip commented Jul 11, 2024

Thanks so much man. Honestly you're a life saver.

@Shadow80456
Copy link

upload the plugin to, 1.20.6, PLS

@JustOneMoreBlock
Copy link
Collaborator

Same file

@Shadow80456
Copy link

Shadow80456 commented Jul 14, 2024 via email

@JustOneMoreBlock
Copy link
Collaborator

  • Update maven plugins dependencies
  • Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping

You can try it with the following provided .jar. Please be cautions using it!

NametagEdit.zip

@JustSimplyGaming
Copy link

  • Update maven plugins dependencies
  • Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping

You can try it with the following provided .jar. Please be cautions using it!
NametagEdit.zip

Hey sorry for the late reply.
At the moment i think it works, but in combination with Ultrapermissions it dosnt work as intended i think.
image

But when its "active":

image

^^'

@Aurelien30000
Copy link
Contributor Author

  • Update maven plugins dependencies
  • Rework a bit packet accessors to support both legacy craft bukkit package versions & modern paper mapping

You can try it with the following provided .jar. Please be cautions using it!
NametagEdit.zip

Hey sorry for the late reply. At the moment i think it works, but in combination with Ultrapermissions it dosnt work as intended i think. image

But when its "active":

image

^^'

As far as I know this plugin may not be directly supported. I don't think it is related to the 1.21 update, please tell me if it is not the case. Note that NameTagEdit has its own handling and probably overrides all other changes made from other plugins such as Ultrapermissions (that are not aware of NTE).

@JustSimplyGaming
Copy link

Thats strange cause UltraPermission names just your Plugin as functional. If i remove it, UltraPermission says that for this function "NameTagEdit" is needed.

@gosuper2
Copy link

  • Обновление зависимостей плагинов maven
  • Немного переработаны методы доступа к пакетам для поддержки как устаревших версий пакета Craft bukkit, так и современного бумажного сопоставления

Вы можете попробовать это с помощью следующих предоставленных . Пожалуйста, будьте осторожны при его использовании!.jar

NametagEdit.zip
Hi, your plugin works perfectly on version 1.21, could you post it on the spigot website, I just use aternos for playing with friends, and there are no more normal plugins for prefixes in the tab

@Aurelien30000
Copy link
Contributor Author

Thats strange cause UltraPermission names just your Plugin as functional. If i remove it, UltraPermission says that for this function "NameTagEdit" is needed.

Right, sorry for the confusion. I can't really see what would cause that on our side. Can you reproduce it on older versions (e.g. 1.20.4)?

@Erlpil
Copy link

Erlpil commented Aug 10, 2024

Hello! Thanks for providing this build. It worked great on 1.21!
For info: This breaks on the new 1.21.1 just released. I ran their build nr. 2 for 1.21.1
Here is the error: pastebin.com/raw/reyaJp9m

@Aurelien30000
Copy link
Contributor Author

@Erlpil Thanks for the feedback. The provided plugin has been updated, you can try it out!

@mxz7
Copy link

mxz7 commented Aug 21, 2024

@Aurelien30000 hex colours don't seem to work for usernames, it uses the last digit of the hex code as the username colour

image

@Aurelien30000
Copy link
Contributor Author

Aurelien30000 commented Aug 21, 2024

@mxz7 That's a weird issue but you are right, it seems that combined color codes/non standard colors (as last) no longer work. I have also noticed that simple formatting such as &4&l is affected for player names.

I will investigate further & try to fix the issue.

@Aurelien30000
Copy link
Contributor Author

Aurelien30000 commented Aug 24, 2024

Apparently, from the first checks I have done, the method used by NTE (team) is no longer suitable for "coloring" the player name as before (bold, previous colors from the prefix, etc.). Only basic colors may be supported. The issue could be fixed by using an alternative method or another plugin.

Anyways, I will make further investigations and maybe try to make a Mojang report.

@mxz7
Copy link

mxz7 commented Aug 28, 2024

Yeah I moved to TAB and seems to work better for my needs, a bit more complicated but way more features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants