Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test cases for DatePicker & TimePicker #92

Merged
merged 4 commits into from
May 31, 2021

Conversation

prateekshourya29
Copy link
Contributor

PR Details

Description

  • Add Test case for the DatePicker and TimePicker component.
  • Fix TimePicker 12 hour format.
  • Add className to Calendar.

Uncovered Lines

  • DatePicker: 107-110
  • TimePicker: 33-34,43-50,73-79,262,266

Related Issue

#39

Motivation and Context

For test coverage.

How Has This Been Tested

Tested using jest with the help of react testing library.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #92 (a2f7495) into master (32122ad) will increase coverage by 4.62%.
The diff coverage is 97.29%.

❗ Current head a2f7495 differs from pull request most recent head cfff1b0. Consider uploading reports for the commit cfff1b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   75.44%   80.07%   +4.62%     
==========================================
  Files         140      140              
  Lines        2167     2178      +11     
  Branches      530      535       +5     
==========================================
+ Hits         1635     1744     +109     
+ Misses        528      432      -96     
+ Partials        4        2       -2     
Impacted Files Coverage Δ
src/components/Calendar/Calendar.tsx 100.00% <ø> (ø)
src/components/DatePicker/TimePicker.tsx 83.47% <97.29%> (+68.92%) ⬆️
src/components/Popover/Popover.tsx 95.12% <0.00%> (+2.43%) ⬆️
src/components/DatePicker/style.ts 100.00% <0.00%> (+33.33%) ⬆️
src/components/DatePicker/DatePicker.tsx 100.00% <0.00%> (+64.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32122ad...cfff1b0. Read the comment docs.

@anitnilay20 anitnilay20 merged commit 34c0b38 into master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants