Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigureControllerTest::testIndex failing on master #1647

Closed
nodiscc opened this issue Nov 22, 2020 · 0 comments · Fixed by #1648
Closed

ConfigureControllerTest::testIndex failing on master #1647

nodiscc opened this issue Nov 22, 2020 · 0 comments · Fixed by #1648
Labels
bug it's broken!
Milestone
0.12.2

Comments

@nodiscc
Copy link
Member

nodiscc commented Nov 22, 2020

As shown in https://github.com/shaarli/Shaarli/runs/1412034972 -> https://travis-ci.com/github/shaarli/Shaarli/jobs/441515544

There was 1 failure:

1) Shaarli\Front\Controller\Admin\ConfigureControllerTest::testIndex
Failed asserting that actual size 6 matches expected size 5.

/home/travis/build/shaarli/Shaarli/tests/front/controller/admin/ConfigureControllerTest.php:65
/home/travis/build/shaarli/Shaarli/vendor/phpunit/phpunit/phpunit:61

It's failing since #1642 was merged, was ok before that. static::assertCount(5, $assignedVariables['languages']); should be updated to 6 since a new language was added.
@nodiscc nodiscc added the bug it's broken! label Nov 22, 2020
nodiscc added a commit to nodiscc/Shaarli that referenced this issue Nov 22, 2020
@nodiscc
ConfigureControllerTest.php: update expected languages number to 6
70507b8 
Following the addition of russian translations in shaarli#1642
Fixes shaarli#1647
@nodiscc nodiscc mentioned this issue Nov 22, 2020
Merged
@ArthurHoaro ArthurHoaro added this to the 0.12.2 milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug it's broken!
Projects
None yet
Milestone
0.12.2
Development

Successfully merging a pull request may close this issue.

ConfigureControllerTest.php: update expected languages number to 6 nodiscc/Shaarli
2 participants
@ArthurHoaro @nodiscc