Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Make Shaarli a Sandstorm.io app #499

Closed
jibe-b opened this issue Feb 26, 2016 · 7 comments
Closed

Feature request: Make Shaarli a Sandstorm.io app #499

jibe-b opened this issue Feb 26, 2016 · 7 comments
Labels
3rd party interoperability with third-party platforms wontfix

Comments

@jibe-b
Copy link

jibe-b commented Feb 26, 2016

Hi!

Shaarli is a nice software that deserve wider spread, according to me.

Do you know sandstorm.io? I think Shaarli should be added to the apps list.
The concept is to enable existing open source apps to run inside the sandstorm server app, the steps to do it are documented here: https://docs.sandstorm.io/en/latest/developing/

And I noticed that there people who add a bookmark of sandstorm.io inside their Shaarli ;)

http://jcfrog.com/shaarli41/?zGRDiw
http://nicolasmd.com.ar/links/?VQVcRA
http://dotmana.com/shaarli/?IbD6Cg
https://shaa.cicogna.fr/?searchtags=sandstorm
http://river.hoa.ro/search.php?q=tag:personal
http://shaarli.claire-desbois.fr/?searchterm=sandstorm

Best regards

NB: I first posted this here: sebsauvage#230 (my mistake)

@nodiscc
Copy link
Member

nodiscc commented Feb 26, 2016

Copying my comment on the original issue:

I'd prefer avoiding storing resources for third-party projects (https://docs.sandstorm.io/en/latest/vagrant-spk/packaging-tutorial/ .sandstorm file for example) in the Shaarli repository itself. Otherwise we'll end up with a lot of unrelated files for various third-party systems (sandstorm, vagrant, docker, ansible... etc etc etc) If you want to maintain a sandstorm Shaarli package, you can do so in your own repository and we'll gladly link to from the wiki.

@nodiscc nodiscc added feedback needed 3rd party interoperability with third-party platforms labels Feb 26, 2016
@ArthurHoaro
Copy link
Member

Well, if someone can provide a solution to make Shaarli work with Sandstorm.io and a CI solution to update the app on release, we can host it in Shaarli's organization.

I've made a few test, and it's not really easy:

@nodiscc nodiscc added this to the backlog to the future milestone Feb 27, 2016
@jibe-b
Copy link
Author

jibe-b commented Feb 28, 2016

Ok, I hope it can be done. I may help when I find some time (I am not developer so my timescales are longer than yours).

@zeigerpuppy
Copy link

I agree this would be a good sandstorm port.
Ideally it's good with sandstorm ports to retain the benefits of upstream changes.
So the first job would be to document the changes required to get it ported, hopefully then these can just be a change in the build to retain compatibility.

I'd be happy to host/test and do a little coding on this if others are interested.

@ArthurHoaro
Copy link
Member

The changes needed in Shaarli is the configuration management refactoring, which will be done eventually.

About the tools, I've forgotten what I tried back then, but it needs Sandstorm packaging, and a way to make Travis upgrade Shaarli in Sandstorm when a new version is released.

@ArthurHoaro
Copy link
Member

I've worked a bit on this. I was able to go through the install process using the new configuration manager, using only a few hacks.

However, sessions aren't working. Authentication is supposed to be done through Sandstorm SSO using their reverse proxy headers (see the docs). This would require too many changes in Shaarli codebase, and I'm not willing to maintain it.

Most apps present in Sandstorm catalogue are actually forks, specific branches or Sandstorm only app. If anyone still wants to create a fork for this, you can start with this.

@jibe-b
Copy link
Author

jibe-b commented Jul 15, 2017

Sorry for reading this late. Thanks for having attempted to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party interoperability with third-party platforms wontfix
Projects
None yet
Development

No branches or pull requests

5 participants
@zeigerpuppy @ArthurHoaro @nodiscc @jibe-b and others