-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load images with the light lib bLazy.js instead of jQuery #132
Conversation
ArthurHoaro
commented
Mar 1, 2015
- Remove jquery.lazyload lib
- Add blazy lib
- Add a bit of CSS animation
- Delete unused picwall2 template
👍 |
Not blocking for this Pull Request, but please in the future submit separate PRs for separate changes (in this example, 3 PRs would have been nice: libraries, CSS, picwall2.html). This makes merging and discussing easier, for example if the library switch would have been controversial (which I don't think it is), you can at least already have the 2 other changes merged while the discussion on the 3rd continues. |
* Remove jquery.lazyload lib * Add blazy lib * Add a bit of CSS animation * Delete unused picwall2 template
It's done. About separate commits, I understand you're point, but |
Note: this actually nukes all of jQuery and removes this dependency from Shaarli. Otherwise this PR is fine. |
No it doesn't. I just removed lazy loading jQuery plug-in. |
Tested and works perfectly, thanks. I'll merge it tomorrow if nobody disagrees. |
Lazy load images with the light lib bLazy.js instead of jQuery