Add an additional free disk space check before saving the datastore #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On every disk write operation, we check the available free disk space (+ slight marging of arbitrary 500kB), and if there is not enough space we do not attempt to write anything. This should prevent most case of corrupted datastore becoming an empty file due to full HDD. Fixes shaarli#1810
nodiscc
approved these changes
Nov 25, 2022
| $data = self::$phpPrefix . base64_encode(gzdeflate(serialize($links))) . self::$phpSuffix; | ||
| $data = base64_encode(gzdeflate(serialize($links))); | ||
|
|
||
| if (empty($data)) { |
There was a problem hiding this comment.
Why would an empty $data happen?
There was a problem hiding this comment.
If, for any kind of reason, PHP was not able to serialize or compress the bookmarks data.
Sometimes, an invalid UTF-8 character can mess up everything with PHP functions. Better be safe than sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every disk write operation, we check the available free disk space (+ slight marging of arbitrary 500kB), and if there is not enough space we do not attempt to write anything.
This should prevent most case of corrupted datastore becoming an empty file due to full HDD.
Fixes #1810