Hashtag system

[ArthurHoaro]

• Hashtag are auto-linked with a filter search
• Supports unicode
• Compatible with markdown (excluded in code blocks)

Fixes #278

PS: it's a new search type, different from ?searchtag, which isn't really useful.

[nodiscc]

Thank you for the patch. I did not test it yet; just a few questions:

• does this add a new hashtag search field in the toolbar?
• how are hashtags different from original, "normal" tags?
• does searching #sometag in full text or tags search fields return posts with hashtags #sometag ?

I think supporting hashtags is a nice change as it enables typing tags quickly in the description. However I'm concerned that this could make usage/search confusing and/or clutter the UI.

[ArthurHoaro]

does this add a new hashtag search field in the toolbar?

No. I'm already not a big fan of the additional tag search field, I didn't want to add another one.

how are hashtags different from original, "normal" tags?

They're autolinked in descriptions, with ?hashtag=hash. Searching #hash will only return shaares with #hash in their description, not #hashstuff nor hash tag.

does searching #sometag in full text or tags search fields return posts with hashtags #sometag

Full text search will return shaares containing /.*#hash.*/ in any of their fields, I did not change this behaviour. Tag search will return nothing.

---

I didn't link hashtags to the tag search, as suggested in the related issue, because it would mean implicitly or explicitly adding hashtags to the tag list (i.e. ?searchtags=hash will return both #hash in description and hash in taglist). Which is, I think, not the behaviour we want.

I actually spent more time toying with the markdown plugin and the regex than thinking that through. Any opinion is welcome.

[nodiscc]

It looks good, one last question: what does a /?hashtag=hash query return?

I assume it should return all shaares containing #hash in their description? Anything else?

I didn't want to add another one.
They're autolinked in descriptions,

+1 +1

[alexisju]

I assume it should return all shaares containing #hash in their description? Anything else?

I hope/guess it returns also shares associated with tags which have the same keyword of the #hash.

[ArthurHoaro]

No it doesn't, yet.

Searching #hash will only return shaares with #hash in their description, not #hashstuff nor hash tag.

But, it might be a good idea to do so.

[nodiscc]

I don't see the point of having an extra ?hashtag= parameter. Just link occurrences of #hash in descriptions to ?searchtags=hash, which does what you want, and does not introduce a new (confusing) parameter. Am I right?

[ArthurHoaro]

I didn't link hashtags to the tag search, as suggested in the related issue, because it would mean implicitly or explicitly adding hashtags to the tag list (i.e. ?searchtags=hash would return both #hash in description and hash in taglist). Which is, I think, not the behavior we want.

But that might be the behavior we want actually.

[ArthurHoaro]

Updated! All hashtags now create a ?addtag=hash search, which will return shaares containing either #hash in their description, or hash in their taglist. Note that this doesn't affect tag autocompletion.