fix: rectify conditional logic for toEnglish #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 932035401Details
💛 - Coveralls |
saihaj
approved these changes
Jun 12, 2021
Merged
bhajneet
added a commit
that referenced
this pull request
Jun 12, 2021
* build: bump semver * fix: rectify conditional logic for toEnglish (#190) * ci: use shabados release actions (#192) * ci: use shabados actions release * ci: use ci flag for release-it cherry-pick from a7f791f#diff-8bc94a3006768345d17c827c0bb5840e6e4daee6de1c2b1ea672f53f162d171dR14 * ci: use latest verisons of shabados actions (#193) * ci: use shabados actions next (#194) * ci: use release script (#195) * ci: use release script * style: new line * Release 3.2.0 * fix bump * fix bump * merge stuffs Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com> Co-authored-by: ShabadOS Bot <team@shabados.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
the logic was:
so if the mapped letter were
''(empty string) it would result in false, therefore passing through all the suppressed characters.new method is now:
and we have explicitly added a bunch of pass through characters in the ignore array/set. now all the tests pass, if there is something not found in the transliterationMap it will be suppressed / hidden from end result, which is not ideal, but better than what we had before I suppose.
Tests for unexpected behavior
Time spent on PR
30 mins
Linked issues
Fix #185