Custom fields handling causing unexpected behaviour with devise

[peterox]

Adding a Devise users details as a custom field was causing devise to be initialised prior to the controller action being executed. This is due to the fact that the custom fields were being added before the controller action.

Also, custom fields are not being added if an exception was thrown from the controller.

[johnowenatala]

Hi,

checking code, I think problem is here:

LogStasher.custom_fields += after_keys - before_keys
https://github.com/shadabahmed/logstasher/blob/master/lib/logstasher/rails_ext/action_controller/metal/instrumentation.rb#L31

This other file has the same, but now changed to this:
LogStasher::CustomFields.add(*(after_keys - before_keys))
https://github.com/shadabahmed/logstasher/blob/master/lib/logstasher/rails_ext/action_controller/base.rb#L27

By the way, please check this two classes - they seem very similar and looks like they are trying to do the same method override with very little differences, which doesnt look right - and looks like it can be broken very easy.

[MarcGrimme]

You are right. I overlooked this line.

LogStasher.custom_fields += after_keys - before_keys

in lib/logstasher/rails_ext/action_controller/metal/instrumentation.rb. So it needs to be fixed (See #115).

FYI: Both classes are indeed similar should deliver the SAME functionality. I introduced them to offer two ways of using logstasher one with implicit monkey patching and one by explicit documented including.

[shadabahmed]

Closing this as fixed in #115