-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Rails 6.1 changes in a way that is compatible with Rails 5.2 and 6.0 #161
Conversation
That fixes the ActiveJob spec issue. |
@shadabahmed The integration spec fix turned out to be easy once I looked at it - needed to allow the logger to receive I'd still suggest merging #160 , so that connection exclusion is picked up. |
Hi @petergoldstein . Thanks for putting effort on this one. I was also working parallely on this PR - #161. I will try to merge all three - yours, mine and #160 |
18cb2c9
to
2563589
Compare
@shadabahmed It may be tricky to merge this with #162 given they take such different approaches (#162 is essentially a Rails 6.1 only PR). I've rebased and believe that this should now contain a superset of the functionality in #162. |
Sounds good. Will merge this PR. Will also try to get my changes in if I rebase on top of yours |
@shadabahmed Thanks for getting this out there so quickly. |
@shadabahmed This is an attempt to incorporate the Rails 6.1 changes so that the code can run in 5.2 and 6.0.
The major shift is in how the LogStasher::ActiveJob::LogSubscriber inheritance is managed. We use a variable for the parent class, which depends on the version of ActiveJob that is loaded.
This runs green with existing specs on Rails 5.2.x and 6.0.x, and has 6 failures on Rails 6.1.x. Roughly speaking these break down as: