-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mouse wheel and touch scroll not working over popover #2123
base: main
Are you sure you want to change the base?
Conversation
@pa4080 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Hi! I used your fix in my popover component & it worked. Thanks dude <3 . Much love <3 |
Hi! I also have same issue, and solution works well. Thanks, saved my day! |
This solution worked well in my project! |
Hi, coming back here to add suggestion So our final fix is
|
Hi, @NazariiShvets, I've committed your solution to the PR. It works great. Thanks! |
This PR gracefully resolves #607, also resolves #542. These issues are caused by an issue with Radix-ui/primitives which still open for over a year and a half - it is described here: [Dialog][Popover] Scrolling issue when Popover inside Dialog #1159
The current solution simulates an arrow down/up key press when we use the mouse wheel over the problematic popover primitive component.