Fix calendar selected style #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@suleymanbariseser is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
@suleymanbariseser This is awesome. Let's merge this. Can you fix the conflicts please? I'll review and merge. |
…radio buttons (shadcn-ui#224) * Update checkbox.tsx * Update radio-group.tsx * fix(radio-group): update colors for contrast * fix(checkbox): update colors for contrast --------- Co-authored-by: shadcn <m@shadcn.com>
* Add table.tsx * Update table.tsx --------- Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
…ui#310) Remove unused import 'Laptop' in icons.tsx (nextjs-example) Co-authored-by: shadcn <m@shadcn.com>
* fix: add missing deps for Button * fix: use correct dep Co-authored-by: Pablo <its.monotype@gmail.com> * chore: add changeset --------- Co-authored-by: Pablo <its.monotype@gmail.com> Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: shadcn <m@shadcn.com>
* fix(code-block-wrapper): missing ']' in className * fix(code-block-wrapper): re-order tailwind className --------- Co-authored-by: shadcn <m@shadcn.com>
* feat(form): add form component * feat(www): update site styles * feat: add form examples * docs(www): add docs for forms * docs(www): hide tabs for docs demo
* docs: display account form name input error Closes: shadcn-ui#380 * style: remove callback return statement
* perf: avoid unnecessary state subscriptions Closes: shadcn-ui#382 * fix(form): code format --------- Co-authored-by: shadcn <m@shadcn.com>
* refactor: remove usage of uncontrolled input apis within controlled inputs Closes: shadcn-ui#384 * docs: display FormField controlled input usage example --------- Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
…i#682) Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix(npm-commands): pnpx to pnpm dlx * style(www): fix --------- Co-authored-by: shadcn <m@shadcn.com>
…hadcn-ui#702) * Update data-table-toolbar.tsx * style(www): run format:write --------- Co-authored-by: shadcn <m@shadcn.com>
…iewports (shadcn-ui#717) * Prevent accordion chevron from shrinking on smaller viewports * fix: apply feedback
* add support for bun install * fix(cli): add changeset for bun install --------- Co-authored-by: shadcn <m@shadcn.com>
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * feat: added remix installation docs * feat: added tabbed installation docs * fix: remove log statement * fix: cleaned up, restored usage notice, removed vite for now * fix: moved installation.mdx into folder --------- Co-authored-by: Samuel Adebayo <samuel.adebayo@engagetech.com> Co-authored-by: shadcn <m@shadcn.com>
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * docs(www): fix code style --------- Co-authored-by: Samuel Adebayo <samuel.adebayo@engagetech.com> Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs: add installation guide for Gatsby * docs: add PR review changes
* chore(www): update to latest Next.js * feat(www): replace lucide icons
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: shadcn <m@shadcn.com>
Co-authored-by: shadcn <m@shadcn.com>
…ui#898) Co-authored-by: shadcn <m@shadcn.com>
Conflicts are fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Selected date has a background color that does not have rounded borders as explained in #269
Issue
To understand if date is selected or not, has([aria-selected]) is used with first selector. The problem, first selector will not check the first day with aria-selected in a week. Instead it checks if the first day of the week has aria-selected or not. Therefore, it only works for the first day of the week. It can be shown here
Solution
The current approach only does not work for start and end dates. Therefore, we can use external classes to style them (day-range-start and day-range-end).