Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navigation-menu #31

Merged
merged 10 commits into from
Jan 29, 2023
Merged

feat: navigation-menu #31

merged 10 commits into from
Jan 29, 2023

Conversation

Ventinc
Copy link
Contributor

@Ventinc Ventinc commented Jan 27, 2023

Navigation Menu Primitive

navigation-menu.mov

@vercel
Copy link

vercel bot commented Jan 27, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @shadcn on Vercel.

@shadcn first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-template ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 5:24PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 29, 2023 at 5:24PM (UTC)

@shadcn
Copy link
Collaborator

shadcn commented Jan 27, 2023

What!! Thank you. Let me QA.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ventinc This is looking great. Thank you.

I left a few comments.

I'm also seeing a small issue with the display here. See screenshot.

b1bJOhpf

apps/www/components/ui/navigation-menu.tsx Show resolved Hide resolved
apps/www/components/ui/navigation-menu.tsx Outdated Show resolved Hide resolved
apps/www/components/ui/navigation-menu.tsx Outdated Show resolved Hide resolved
apps/www/components/ui/navigation-menu.tsx Outdated Show resolved Hide resolved
apps/www/components/ui/navigation-menu.tsx Outdated Show resolved Hide resolved
@Ventinc
Copy link
Contributor Author

Ventinc commented Jan 27, 2023

Demo design is fixed too

@shadcn
Copy link
Collaborator

shadcn commented Jan 29, 2023

@Ventinc This is looking good. I have a WIP component for NavigationMenu as well. If it's OK with you, I'll push my changes to this PR. We can review here.

@Ventinc
Copy link
Contributor Author

Ventinc commented Jan 29, 2023

Yeah, let's do this !

@shadcn
Copy link
Collaborator

shadcn commented Jan 29, 2023

@Ventinc I'm updated the code style a bit to match the other components. I've also removed the submenu and vertical demos for now.

@shadcn shadcn merged commit a0b1f89 into shadcn-ui:main Jan 29, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
* feat: navigation-menu

* fix: export at the end

* fix: rounded-md

* fix: demo design

* rename: NavigationMenuRoot -> NavigationMenu

* feat: update roadmap

* feat: update style for navigation menu

* feat: implement navigation menu component

* feat: implement navigation menu for www

---------

Co-authored-by: shadcn <m@shadcn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants