fix(docs): correct command documentation in combobox #3769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fran-veiras is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
approved these changes
May 19, 2024
|
LGTM ✨, Nice work @fran-veiras Any update about merging this fix? @shadcn |
piotrprzybytniewski
approved these changes
Jul 3, 2024
|
@fran-veiras I think this was fixed in another PR. Closing this for now. But please reopen if not. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Documentation for Combobox Command
In this update, I corrected the documentation for the Combobox command to ensure clarity and accuracy. The following changes were made:
https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0
Rendering the Command.List part (CommandList if using shadcn) is now mandatory.
These changes fix the following bug:
#2980