Update combobox-demo.tsx for cmdk v1.0.0 #3872
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since cmdk v1.0.0, CommandEmpty and CommandGroup have to be wrapped in CommandList, otherwise it throws the following error: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
|
@alexheckmann is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
approved these changes
May 30, 2024
|
was looking for this issue before few days, finally solved |
cristianbgp
approved these changes
Jun 1, 2024
|
any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since cmdk v1.0.0, CommandEmpty and CommandGroup have to be wrapped in CommandList, otherwise it throws the following error as described in Issue #2980:
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
To give people a working solution, here is an updated example of the combobox component that implements the compatibility fix.