feat: add chart colors to theme customizer #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@creativoma is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@creativoma thanks for adding this. looks good. can you run |
shadcn
added
area: www
postpone: more info or changes requested
|
Thank you for all your contributions to the community! |
shadcn
approved these changes
Jul 10, 2024
shadcn
added
automerge
and removed
postpone: more info or changes requested
tangtai
pushed a commit
to tangtai/ui
that referenced
this pull request
Aug 29, 2024
# Description This PR adds support for customizing graphics themes in the `ThemeCustomizer` component. Users can now select and copy chart colors (`chart-1`, `chart-2`, `chart-3`, `chart-4`, `chart-5`) along with other themes. ## Changes Implemented 1. **Themes Update**: Added chart themes (`chart-1`, `chart-2`, `chart-3`, `chart-4`, `chart-5`) to the chart file. themes configuration (`themes.ts`). 2. **Modification of the `ThemeCustomizer` Component**: The new graphics themes were integrated into the component so that they can be selected and copied. 3. **CSS Tweak**: Updated the functions that generate CSS code to include the new graphics themes. ## How to Test 1. Run the project locally. 2. Navigate to the `ThemeCustomizer` component. 3. Verify that the new graphics themes are available for selection. 4. Test the functionality of copying the CSS code and making sure it includes the graphics colors. ## References - Added support for graphics themes based on defaults provided by Shadcn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for customizing graphics themes in the
ThemeCustomizercomponent. Users can now select and copy chart colors (chart-1,chart-2,chart-3,chart-4,chart-5) along with other themes.Changes Implemented
chart-1,chart-2,chart-3,chart-4,chart-5) to the chart file. themes configuration (themes.ts).ThemeCustomizerComponent: The new graphics themes were integrated into the component so that they can be selected and copied.How to Test
ThemeCustomizercomponent.References