Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chars): removed the chart from 'View Code' sheet from /charts #4244

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

xSenny
Copy link
Contributor

@xSenny xSenny commented Jul 10, 2024

I removed the chart preview, because it stopped people to get the code with lower screen resolutions

here you can see an issue about this.

Copy link

vercel bot commented Jul 10, 2024

@xSenny is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@xSenny
Copy link
Contributor Author

xSenny commented Jul 10, 2024

image
I added now an easy way to switch between Chart preview / Code / Theme

@shadcn
Copy link
Collaborator

shadcn commented Jul 11, 2024

Let's try and keep both. We could adjust the height of the code section instead.

@xSenny
Copy link
Contributor Author

xSenny commented Jul 11, 2024

Sure, I guess that I added the new tab looks way better, cause the code is already scrollable

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 10:47am

@shadcn shadcn merged commit 5b85612 into shadcn-ui:main Jul 16, 2024
7 checks passed
tangtai pushed a commit to tangtai/ui that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants