fix: Playground example model selector working #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbsangu is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tangtai
pushed a commit
to tangtai/ui
that referenced
this pull request
Aug 29, 2024
Issue: The ModelItem component's onPeek handler was sometimes logging incorrect data, causing the model selector to appear inconsistent. Changes Made: Verified that the aria-selected attribute is true before calling onPeek(model), ensuring the function is only called when the element is actually selected. Fixed Model Selector Inconsistency in Playground Example fixes shadcn-ui#4506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The ModelItem component's onPeek handler was sometimes logging incorrect data, causing the model selector to appear inconsistent.
Changes Made:
Verified that the aria-selected attribute is true before calling onPeek(model), ensuring the function is only called when the element is actually selected.
Fixed Model Selector Inconsistency in Playground Example
fixes #4506