Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packUnorm4x8 (and possibly related functions) do not function properly/as-expected. #4031

Closed
ArielG-NV opened this issue Apr 25, 2024 · 0 comments · Fixed by #4033
Closed

packUnorm4x8 (and possibly related functions) do not function properly/as-expected. #4031

ArielG-NV opened this issue Apr 25, 2024 · 0 comments · Fixed by #4033
Assignees
@jkwak-work
Labels
goal:client support Feature or fix needed for a current slang user. kind:bug something doesn't work like it should

Comments

@ArielG-NV
Copy link
Contributor

ArielG-NV commented Apr 25, 2024 •
edited
Loading 

uint tt = packUnorm4x8(float4(1, 0, 0, 1));
hit.color = unpackUnorm4x8(tt);

hit.color != float4(1, 0, 0, 1)
@ArielG-NV ArielG-NV added kind:bug something doesn't work like it should goal:client support Feature or fix needed for a current slang user. labels Apr 25, 2024
jkwak-work added a commit to jkwak-work/slang that referenced this issue Apr 25, 2024
@jkwak-work
Fix unpackUnorm4x8 and unpackSnorm4x8
a5e87da 
Fixes shader-slang#4031

Each component of unpackU/Snorm4x8 had to be masked for 8bits.
@jkwak-work jkwak-work mentioned this issue Apr 25, 2024
Merged
csyonghe pushed a commit that referenced this issue Apr 25, 2024
@jkwak-work
Fix unpackUnorm4x8 and unpackSnorm4x8 (#4033)
bc7231b 
Fixes #4031

Each component of unpackU/Snorm4x8 had to be masked for 8bits.
@cheneym2 cheneym2 mentioned this issue May 23, 2024
Merged
djohansson pushed a commit to djohansson/slang that referenced this issue Sep 21, 2024
@jkwak-work @djohansson
Fix unpackUnorm4x8 and unpackSnorm4x8 (shader-slang#4033)
d52e30e 
Fixes shader-slang#4031

Each component of unpackU/Snorm4x8 had to be masked for 8bits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwak-work jkwak-work

Labels
goal:client support Feature or fix needed for a current slang user. kind:bug something doesn't work like it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unpackUnorm4x8 and unpackSnorm4x8 jkwak-work/slang
2 participants
@jkwak-work @ArielG-NV