Implement FileCheck tests for several test commands #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Mar 28, 2023
premake5.lua
Outdated
| -- We link with llvm here for FileCheck support, LLVM-14 is the | ||
| -- library required according to llvm-config (llvm-config isn't in the | ||
| -- binary llvm distribution on Windows, so just inline the output here) | ||
| links { "compiler-core", "slang", "core", "miniz", "lz4", "LLVM-13" } |
There was a problem hiding this comment.
This is not done through slang-llvm wrapper?
Does this mean I need to pull llvm repo locally and setup my environment so the llvm headers can be found?
expipiplus1
force-pushed
the
filecheck
branch
3 times, most recently
from
af79031
to
f74519a
Compare
`slang-test -- tests/foo tests/bar`
Makes this issue present consistently: shader-slang#2766
- SIMPLE, SIMPLE_EX - SIMPLE_LINE - REFLECTION, CPU_REFLECTION - CROSS_COMPILE It does not currently support the render tests or the COMPARE_COMPUTE commands It is invoked by adding `(filecheck=MY_FILECHECK_PREFIX)` to the test command, for example TEST:CROSS_COMPILE(filecheck=SPIRV): -target spirv-assembly
Which were waiting on FileCheck
csyonghe
previously approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not currently support the render tests or the COMPARE_COMPUTE commands
It is invoked by adding
(filecheck=MY_FILECHECK_PREFIX)to the test command, for exampleTEST:CROSS_COMPILE(filecheck=SPIRV): -target spirv-assembly
Need to go through and neaten things up, and finish support for the
compute tests (which have both data and compiler diagnostic output to
confuse things).
depends on shader-slang/slang-llvm#64