SPIRV compiler performance fixes. #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expipiplus1
previously approved these changes
Oct 4, 2023
source/slang/slang-emit-spirv.cpp
Outdated
| @@ -4830,6 +4814,7 @@ SlangResult emitSPIRVFromIR( | |||
| // feature so we can skip | |||
| if(SLANG_FAILED(validationResult) && validationResult != SLANG_E_NOT_AVAILABLE) | |||
| { | |||
| File::writeAllBytes("d:\\bug.spv", spirvOut.getBuffer(), spirvOut.getCount()); | |||
source/slang/slang-emit.cpp
Outdated
| String optErr; | ||
| if (SLANG_FAILED(optimizeSPIRV(spirv, optErr, outSpirv))) | ||
| { | ||
| File::writeAllBytes("D:\\problem-spirv.spv", spirv.getBuffer(), spirv.getCount()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes complexity explosion in
simplifyIRwhere we repetitively traverse the entire cfg to determine reachability/dominance.Fixes a bug in constant folding of
bitcast.Implement a pass to turn composite SSA values into memory objects.
Fix a bug in
IRBlock::addParam.Make eliminatePhi pass only process phi nodes of composite types and leave scalar phi nodes as is.
Expose more options for
simplifyIRto avoid performing expensive optimizations where unnecessary.Revise stdlib and get rid of
__spirv_capabilitymodifiers.