Fix build for igraph v0.10.x #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robgjansen
force-pushed
the
fix-build-igraph
branch
2 times, most recently
from
b875bdf
to
434623e
Compare
It only needs to be set once on program startup and then left alone.
robgjansen
force-pushed
the
fix-build-igraph
branch
from
434623e
to
8653552
Compare
|
I appreciate the work that you all do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tgen build on systems with igraph library versions >= 0.10.0. We no longer need to use workarounds to install older version from backports or previous release repositories.
The general strategy here was to implement the tgen code according to the newer igraph api changes from v0.10.x, and then set up the messy compat definitions in
tgen-igraph-compat.hthat we can eventually just delete if we ever decide we no longer want to support igraph versions older than v0.10.0.We also stop setting the C attribute table multiple times during program execution, and just sets it once at program startup as explained in #44 (comment).
Fixes #44