Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global keyboard shortcut to toggle On/Off #206

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Add global keyboard shortcut to toggle On/Off #206

merged 1 commit into from
Jan 13, 2017

Conversation

rizwankce
Copy link
Contributor

  • Added new global hot key Command + Control + S to toggle Shadowsocks runnning mode On/Off.
  • Modified old code to look pretty by reusing func
  • Modified HUD to show lengthy texts

This PR also solves issue 48 which was marked as Enhancement.

@rizwankce rizwankce mentioned this pull request Jan 13, 2017
Closed
qiuyuzhou
qiuyuzhou approved these changes Jan 13, 2017
View reviewed changes
Copy link
Collaborator

@qiuyuzhou qiuyuzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiuyuzhou qiuyuzhou merged commit 489d9fe into shadowsocks:develop Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiuyuzhou qiuyuzhou qiuyuzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rizwankce @qiuyuzhou