Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support #16

Closed
wants to merge 10 commits into from
Closed

Add https support #16

wants to merge 10 commits into from

Conversation

Huang-lin
Copy link
Collaborator

No description provided.

@shafreeck
Copy link
Owner

I have some ideas about how to support https:

  1. Pass scheme as part of address, for example use: http://192.168.0.1, http://192.168.0.2 or https://192.168.0.1, https://192.168.0.2 instead of current 192.168.0.1, 192.168.0.2
  2. Add cetcd_setup_tls as you did to support custom cert files. The caller decide using it or not. The default trusted cert will be used if cetcd_setup_tls was not called.

This will be more simpler to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants