Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reservation controller endpoints #38

Closed
wants to merge 2 commits into from

Conversation

shahadat3669
Copy link
Owner

Rent Home Now API: Add Reservation Controller #10

Project Requirement

  • Create routes for reservations
    • /api/v1/reservations
    • for reservations
      • required start_date, end_date, property_id, guests attributes
      • require Authorization header token
  • Add The Reservations Controler for each operation:
    • Add #index method
    • Add the #show method
    • Add the #create method
    • Add #update method
    • Add #destroy method
  • Add test cases for reservations controller

General requirements

@shahadat3669 shahadat3669 added the enhancement New feature or request label May 17, 2023
@shahadat3669 shahadat3669 self-assigned this May 17, 2023
@shahadat3669 shahadat3669 linked an issue May 17, 2023 that may be closed by this pull request
@shahadat3669 shahadat3669 marked this pull request as ready for review May 17, 2023 19:10
@sambeck87 sambeck87 self-requested a review May 17, 2023 19:16
Copy link
Collaborator

@sambeck87 sambeck87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 ✔️

Hi @shahadat3669 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 🎯

✔️ Descriptive PR
✔️ Used Gitflow 📌
✔️ No linter errors

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@shahadat3669 shahadat3669 deleted the feature/reservation-controller-endpoints branch May 17, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Create the reservation controller for API
2 participants