Use deprecate instead of alwaysWarn

shaka-project · Apr 24, 2024 · 19177ab · 19177ab
1 parent dbff858
commit 19177ab
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/player.js b/lib/player.js
@@ -2091,7 +2091,9 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
     if (textDisplayer.configure) {
       textDisplayer.configure(this.config_.textDisplayer);
     } else {
-      shaka.log.alwaysWarn('Text displayer should have a "configure" method!');
+      shaka.Deprecate.deprecateFeature(5,
+          'Text displayer w/ configure',
+          'Text displayer should have a "configure" method!');
     }
     this.lastTextFactory_ = textDisplayerFactory;
 
@@ -3444,7 +3446,8 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
         if (displayer.configure) {
           displayer.configure(this.config_.textDisplayer);
         } else {
-          shaka.log.alwaysWarn(
+          shaka.Deprecate.deprecateFeature(5,
+              'Text displayer w/ configure',
               'Text displayer should have a "configure" method!');
         }
         this.mediaSourceEngine_.setTextDisplayer(displayer);

diff --git a/lib/text/text_engine.js b/lib/text/text_engine.js
@@ -7,7 +7,7 @@
 goog.provide('shaka.text.TextEngine');
 
 goog.require('goog.asserts');
-goog.require('shaka.log');
+goog.require('shaka.Deprecate');
 goog.require('shaka.media.ClosedCaptionParser');
 goog.require('shaka.text.Cue');
 goog.require('shaka.util.BufferUtils');
@@ -153,13 +153,15 @@ shaka.text.TextEngine = class {
     if (this.parser_.setSequenceMode) {
       this.parser_.setSequenceMode(sequenceMode);
     } else {
-      shaka.log.alwaysWarn(
+      shaka.Deprecate.deprecateFeature(5,
+          'Text parsers w/ setSequenceMode',
           'Text parsers should have a "setSequenceMode" method!');
     }
     if (this.parser_.setManifestType) {
       this.parser_.setManifestType(manifestType);
     } else {
-      shaka.log.alwaysWarn(
+      shaka.Deprecate.deprecateFeature(5,
+          'Text parsers w/ setManifestType',
           'Text parsers should have a "setManifestType" method!');
     }
     this.segmentRelativeVttTiming_ = segmentRelativeVttTiming;