-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmux in a worker #1735
Comments
I suspect that the problem is similar to #1704 |
@avelad looks so. Btw, I've tried your decision with looking for webos ua, but the problem didnt pass. |
Ive extracted transmuxing logic to worker, js-timings become cool. But big freezings still remained (lol) |
@Kogoruhn since you and @avelad both see this as similar to #1704 I am going to label in the same way. However like in #1704, I am not sure how much we will be able to do since we are not well set-up to test smart tvs. In the meantime, I would encourage you to contribute to the conversation in the #1753 which is about exploring ways that we can all work together to better investigate SmartTV issues. |
@vaage , Is it possible isolate transmuxing logic into worker (https://caniuse.com/#search=web%20workers) inside Shaka Player? |
I just tested with link removed and the fix for #1820 and I don't see the stall in webos. Still, I think it would be nice to move mux.js to a worker. |
@avelad I think so too :) |
@avelad, to my understanding, we can't use service works in the Player library. We have one with the demo, but not in the library. My understanding (which could be out-of-date) is an app can only have one service worker, so if we were to add one in the library, it would conflict with the application. What is the goal of moving transmuxing? |
@vaage web workers are different than service workers. See https://bitsofco.de/web-workers-vs-service-workers-vs-worklets/ |
@avelad Thank you for providing the additional information, that looks very interesting and useful in more than one space. Adopting this sounds like it would be a shift in architecture. Decisions like this are above my level, @joeyparrish, what are your thoughts on this? |
When i create my own worker, i have keeked in videojs transmuxer worker. If anybody want, i can attach result here. |
Since the fix for #1820 is working with the content here, this doesn't seem to be a unique bug. But I think transmuxing in a worker thread would be great. I've renamed the issue to reflect the goal, and tagged it as "enhancement". |
Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
2.5.0-beta2
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from
master
?:Yes
Are you using the demo app or your own custom app?:
custom
If custom app, can you reproduce the issue using our demo app?:
not applicable
What browser and OS are you using?:
webOS/Tizen
What are the manifest and license server URIs?:
What did you do?
try to play various hls streams
What did you expect to happen?
normal playback
What actually happened?
WebOS: video plays 0.5-2-10 sec, then freezing on 0.5-2-20 sec (depends on stream);
Tizen: barely noticeable freezings of playback.
Streams are not buggy - BBC TAL HTML5 player & videojs plays these hls on these smarttv-s normally.
This issue a bit like that, gap jumping fires time after time (and
Flushing media pipeline
too)player.getConfiguration().streaming:
logs (use horisontal scroll at the bottom)
The text was updated successfully, but these errors were encountered: