-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stalls on WebOS #1820
Fix stalls on WebOS #1820
Conversation
From a technical stand-point, this looks good, but there are some structural changes I would like, but I want @joeyparrish to chime in:
@avelad Could you offer me some feedback? The files you changed were created from some recent refactoring in which I move the stall detector and platform code into their own classes. Did that make it easier for you to find where to make your changes? |
Given that we have platform checks isolated in
Yes, long term, I think greater modularity could be nice. Stall detection could even be disabled via configuration at that point. For now, though, it's not needed. We can file that as an issue to come back to at a later time.
Yes, please. @avelad, if you could add a brief comment to the code, that would help. I left a suggestion on the code itself. Looks good to me otherwise! Thanks! |
@joeyparrish I update the comment with your suggestion (that is the real problem) |
This PR seems fixes the problem on WebOS. |
thanks for your info @skipness |
All tests passed! |
Hi Joey, We are getting consistently good results on VOD content on Web OS but have frequent buffering issue when we pass over discontinuities for SSAI ad breaks where bitrates / resolutions change. They eventually recover, but sometimes the buffering can take up to 5-10 seconds which leads to a really bad user experience. We don't see this with other players but need to use ShakaPlayer to support DRM for VOD content (no DRM on live linear) on WebOS. We also experience quite slow load times (5 seconds+).
I can send a test stream via email but not here. Thanks |
Fix for #1704