Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resuming after buffering #190

Closed
gonemad opened this issue Sep 24, 2015 · 2 comments
Closed

Improve resuming after buffering #190

gonemad opened this issue Sep 24, 2015 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@gonemad
Copy link

gonemad commented Sep 24, 2015

I have been having an issue where once shaka gets into a buffering state, it will not stop buffering until I click play again. After some investigation I have determined it was because of the buffer size i gave the player. I want to buffer ahead as much as possible so i set the buffer size to be around 10 minutes (so playing back at faster speeds involves less buffering). This works find and dandy on startup as playback starts immediately and my client will download 10 minutes worth of future video chunks. However when shaka enters the buffering state, it will not exit this state until that entire 10 minutes worth of buffer is filled.

var bufferingGoal = this.videoSource_.getBufferingGoal();
if (buffered > bufferingGoal) {
this.endBufferingState_();
this.video_.play();
}

I recommend either splitting the buffering configuration into a maxBufferSize and a targetBufferSize (where targetBufferSize is the threshold needed before playback is resumed) or using something like

if (buffered > shaka.player.Player.UNDERFLOW_THRESHOLD_)

to resume playback

@tdrews tdrews added the type: enhancement New feature or request label Sep 24, 2015
@tdrews tdrews added this to the Future milestone Sep 24, 2015
@tdrews
Copy link
Contributor

tdrews commented Sep 24, 2015

Good suggestion.

We've been having some discussion about improving Stream configuration (i.e., adding finer grained control), so we can address this issue as part of our plan.

@TheModMaker TheModMaker self-assigned this Oct 8, 2015
@TheModMaker TheModMaker modified the milestones: v1.6.0, Future Oct 12, 2015
@TheModMaker
Copy link
Contributor

Now you can to set the streamBufferSize configuration to a large value and the player will use the MPD minBufferSize to determine how much to buffer before playback resumes.

TheModMaker added a commit that referenced this issue Nov 11, 2015
Closes #190

Change-Id: Iee663056ce221e8388b9e6bd7b78f587c8ed0191
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants