Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize clock does not take into account caching of fragments #191

Closed
kfwerf opened this issue Sep 25, 2015 · 1 comment
Closed

Synchronize clock does not take into account caching of fragments #191

kfwerf opened this issue Sep 25, 2015 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kfwerf
Copy link

kfwerf commented Sep 25, 2015

Hey guys,

We noticed an issue with the ajax request, it takes in the date from our cdn, however that date reflects when the fragment was cached, not current time. An improvement could be to take the age into account as well.

We had to outcomment it for now and probably rely on our own api to give a reliable timing as this implementation threw our clock of by more than 30 minutes.

https://github.com/google/shaka-player/blob/master/lib/util/ajax_request.js#L447-L458

@tdrews tdrews added the type: bug Something isn't working correctly label Sep 25, 2015
@tdrews tdrews added this to the v1.6.0 milestone Sep 25, 2015
@tdrews
Copy link
Contributor

tdrews commented Sep 25, 2015

Thanks for the report. This is a bug: Date gives the time when the content was created; not when it was transported (see https://tools.ietf.org/html/rfc7231#section-7.1.1.2).

@TheModMaker TheModMaker self-assigned this Sep 29, 2015
TheModMaker added a commit that referenced this issue Oct 7, 2015
Closes #191

Change-Id: I66086ad247a0deec34756ae70ea4e3ddfc5fd264
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants