Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEA 608 captions not work with H.265 video streams #5251

Closed
caridley opened this issue May 30, 2023 · 0 comments · Fixed by #5252
Closed

CEA 608 captions not work with H.265 video streams #5251

caridley opened this issue May 30, 2023 · 0 comments · Fixed by #5252
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@caridley
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.4

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Chrome on Mac OS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
NA

What are the manifest and license server URIs?
I don't have a stream we can share, but we will submit an MR to fix this.

What configuration are you using? What is the output of player.getConfiguration()?
NA

What did you do?
Play an H.265 video stream that contains CEA 608 captions

What did you expect to happen?
Expected to see captions.

What actually happened?
Did not see captions because of a parsing error in mp4_cea_parser which does not handle the 2 byte nal unit header used in H.265

See section 7.3.1.2 "NAL unit header syntax" in H.265 specification.

Thanks to Moin Pansare for diagnosing this problem.
@caridley caridley added the type: bug Something isn't working correctly label May 30, 2023
@caridley caridley mentioned this issue May 30, 2023
Merged
@github-actions github-actions bot added this to the v4.4 milestone May 30, 2023
avelad pushed a commit that referenced this issue May 31, 2023
@caridley
fix: CEA 608 captions not work with H.265 video streams (#5252)
f0ee16b 
Fix parsing of CEA 608 captions in H.265 video streams by handling 2
byte nal unit header.

Fixes #5251
@github-actions github-actions bot mentioned this issue May 31, 2023
Merged
JulianDomingo pushed a commit that referenced this issue Jun 20, 2023
@caridley @JulianDomingo
fix: CEA 608 captions not work with H.265 video streams (#5252)
b08bb41 
Fix parsing of CEA 608 captions in H.265 video streams by handling 2
byte nal unit header.

Fixes #5251
@github-actions github-actions bot mentioned this issue Jun 9, 2023
Merged
JulianDomingo pushed a commit that referenced this issue Jun 21, 2023
@github-actions
chore(v4.3.x): release 4.3.7 (#5255)
203231d 
🤖 I have created a release *beep* *boop*
---


##
[4.3.7](v4.3.6...v4.3.7)
(2023-06-21)


### Bug Fixes

* CEA 608 captions not work with H.265 video streams
([#5252](#5252))
([b08bb41](b08bb41)),
closes
[#5251](#5251)
* **Demo:** Fix deployment of codem-isoboxer in the Demo
([#5257](#5257))
([7e2903a](7e2903a))
* **demo:** Fix deployment of v4.3.x on appspot
([ccf5e2e](ccf5e2e))
* **Demo:** Fix error link width to avoid overlap with close button
([#5309](#5309))
([f575dab](f575dab))
* Fix error when network status changes on src= playbacks
([#5305](#5305))
([cf683f5](cf683f5))
* **HLS:** Avoid "Possible encoding problem detected!" when is a preload
reference
([#5332](#5332))
([9ce8cc0](9ce8cc0))
* **HLS:** Avoid HLS resync when there is a gap in the stream
([#5284](#5284))
([679dbae](679dbae))
* **HLS:** Avoid variable substitution if no variables
([#5269](#5269))
([49afa92](49afa92))
* **HLS:** Fix HLS seekRange for live streams
([#5263](#5263))
([03df9cb](03df9cb))
* **HLS:** Fix seekRange for EVENT playlist not using
EXT-X-PLAYLIST-TYPE
([#5220](#5220))
([562831b](562831b))
* **HLS:** Parse EXT-X-PART-INF as media playlist tag
([#5311](#5311))
([f6210ee](f6210ee))
* **HLS:** Skip EXT-X-PRELOAD-HINT without full byterange info
([#5294](#5294))
([9e193e2](9e193e2))
* media source object URL revocation
([#5214](#5214))
([1a89daa](1a89daa))
* Ship to NPM without node version restrictions
([#5253](#5253))
([ca096a8](ca096a8)),
closes
[#5243](#5243)
* unnecessary parsing of in-band pssh when pssh is in the manifest
([#5198](#5198))
([8d6494d](8d6494d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cristian-atehortua cristian-atehortua mentioned this issue Jul 14, 2023
Closed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
gkatsev pushed a commit to sky-hugolima/shaka-player-contrib that referenced this issue Dec 6, 2023
@tykus160 @friday
@avelad @joeyparrish @caridley @littlespex
[PATCH][v4] cherry pick of needed changes from upstream (shaka-projec…
ca5942e 
…t#306)

* [PATCH] fix(dash): fix race condition in segment template (shaka-project#5842)

Fixes shaka-project#5760

* fix(cea): Fix not rendering CEA-608 Closed Captions (shaka-project#4683)

Also added H265 support and a framework for future TS CEA parser support.

Fixes shaka-project#4605
Fixes shaka-project#3659

Co-authored-by: Joey Parrish <joeyparrish@google.com>

* fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments (shaka-project#4756)

Fixes shaka-project#4605

Co-authored-by: Joey Parrish <joeyparrish@google.com>

* fix: CEA 608 captions not work with H.265 video streams (shaka-project#5252)

Fix parsing of CEA 608 captions in H.265 video streams by handling 2
byte nal unit header.

Fixes shaka-project#5251

* fix: seeking in segment timeline returns incorrect index (shaka-project#5716)

Resolves shaka-project#5664

---------

Co-authored-by: Albin Larsson <albin.larsson@eyevinn.se>
Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
Co-authored-by: Aidan Ridley <aidan.ridley@charter.corp-partner.google.com>
Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix: CEA 608 captions not work with H.265 video streams caridley/shaka-player
1 participant
@caridley