fix: CEA 608 captions not work with H.265 video streams #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns. See section 7.3.1.2 "NAL unit header syntax" in H.265 specification.
|
Incremental code coverage: 100.00% |
|
@caridley can you add some tests? Thanks! |
avelad
changed the title
avelad
added
type: bug
|
LGTM, only add some test for it. Thanks! |
avelad
approved these changes
May 31, 2023
JulianDomingo
pushed a commit
that referenced
this pull request
Jun 20, 2023
Fix parsing of CEA 608 captions in H.265 video streams by handling 2 byte nal unit header. Fixes #5251
JulianDomingo
pushed a commit
that referenced
this pull request
Jun 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.7](v4.3.6...v4.3.7) (2023-06-21) ### Bug Fixes * CEA 608 captions not work with H.265 video streams ([#5252](#5252)) ([b08bb41](b08bb41)), closes [#5251](#5251) * **Demo:** Fix deployment of codem-isoboxer in the Demo ([#5257](#5257)) ([7e2903a](7e2903a)) * **demo:** Fix deployment of v4.3.x on appspot ([ccf5e2e](ccf5e2e)) * **Demo:** Fix error link width to avoid overlap with close button ([#5309](#5309)) ([f575dab](f575dab)) * Fix error when network status changes on src= playbacks ([#5305](#5305)) ([cf683f5](cf683f5)) * **HLS:** Avoid "Possible encoding problem detected!" when is a preload reference ([#5332](#5332)) ([9ce8cc0](9ce8cc0)) * **HLS:** Avoid HLS resync when there is a gap in the stream ([#5284](#5284)) ([679dbae](679dbae)) * **HLS:** Avoid variable substitution if no variables ([#5269](#5269)) ([49afa92](49afa92)) * **HLS:** Fix HLS seekRange for live streams ([#5263](#5263)) ([03df9cb](03df9cb)) * **HLS:** Fix seekRange for EVENT playlist not using EXT-X-PLAYLIST-TYPE ([#5220](#5220)) ([562831b](562831b)) * **HLS:** Parse EXT-X-PART-INF as media playlist tag ([#5311](#5311)) ([f6210ee](f6210ee)) * **HLS:** Skip EXT-X-PRELOAD-HINT without full byterange info ([#5294](#5294)) ([9e193e2](9e193e2)) * media source object URL revocation ([#5214](#5214)) ([1a89daa](1a89daa)) * Ship to NPM without node version restrictions ([#5253](#5253)) ([ca096a8](ca096a8)), closes [#5243](#5243) * unnecessary parsing of in-band pssh when pssh is in the manifest ([#5198](#5198)) ([8d6494d](8d6494d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of CEA 608 captions in H.265 video streams by handling 2 byte nal unit header.
Fixes #5251