fix(dash): fix race condition in segment template #5842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Nov 2, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
gkatsev
pushed a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Dec 6, 2023
…t#306) * [PATCH] fix(dash): fix race condition in segment template (shaka-project#5842) Fixes shaka-project#5760 * fix(cea): Fix not rendering CEA-608 Closed Captions (shaka-project#4683) Also added H265 support and a framework for future TS CEA parser support. Fixes shaka-project#4605 Fixes shaka-project#3659 Co-authored-by: Joey Parrish <joeyparrish@google.com> * fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments (shaka-project#4756) Fixes shaka-project#4605 Co-authored-by: Joey Parrish <joeyparrish@google.com> * fix: CEA 608 captions not work with H.265 video streams (shaka-project#5252) Fix parsing of CEA 608 captions in H.265 video streams by handling 2 byte nal unit header. Fixes shaka-project#5251 * fix: seeking in segment timeline returns incorrect index (shaka-project#5716) Resolves shaka-project#5664 --------- Co-authored-by: Albin Larsson <albin.larsson@eyevinn.se> Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com> Co-authored-by: Joey Parrish <joeyparrish@google.com> Co-authored-by: Aidan Ridley <aidan.ridley@charter.corp-partner.google.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #5061.
If
.release()is called between the timecreateUrisCb()is created and when it's called, thenthis.templateInfo_is set to null, causing #5614 and #5760. The fix in #5619 may have been enough to fix or silence #5614, but it wasn't enough to fix #5760, which is the issue I'm having (at least I'm getting the same error).Maybe @nrcrast can confirm this is the correct
this.templateInfo_.mediaTemplateto pass tocreateUris_()? I don't fully understand the segment template (I have git bisected my way to find the issue). The initial PR draft for #5061 didn't actually have the race condition. It was introduced when addressing feedback about using.bind()for createUrisCb: #5061 (comment). So to me it seems like that change was unintentional.