Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebVTT): Fix wrong writing-mode in nested cues #5641

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(WebVTT): Fix wrong writing-mode in nested cues #5641

merged 1 commit into from
Sep 12, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 12, 2023

Fixes #4765

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Sep 12, 2023
@avelad avelad added this to the v4.5 milestone Sep 12, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 56a4cea into shaka-project:main Sep 12, 2023
20 of 21 checks passed
@avelad avelad deleted the writing-mode-webvtt branch September 12, 2023 10:19
@shaka-bot shaka-bot mentioned this pull request Sep 12, 2023
Closed
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)
8a7e32e 
Fixes #4765
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)
ba9a852 
Fixes #4765
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2023
Merged
avelad added a commit to avelad/shaka-player that referenced this pull request Sep 15, 2023
@avelad
Revert "fix(WebVTT): Fix wrong writing-mode in nested cues (shaka-pro…
2213677 
…ject#5641)"

This reverts commit 56a4cea.
avelad added a commit that referenced this pull request Sep 15, 2023
@avelad
revert: "fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)" (#…
6975be9 
…5662)

This reverts commit 56a4cea.

Fixes #5661
@joeyparrish joeyparrish mentioned this pull request Sep 21, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Sep 21, 2023
@avelad @joeyparrish
fix(WebVTT): Fix text displayed out of picture and with overlapping l…
ee898e9 
…ines (#5662)

This reverts commit 56a4cea, PR #5641

Fixes #5661
joeyparrish pushed a commit that referenced this pull request Sep 21, 2023
@avelad @joeyparrish
fix(WebVTT): Fix text displayed out of picture and with overlapping l…
580b3f7 
…ines (#5662)

This reverts commit 56a4cea, PR #5641

Fixes #5661
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 11, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

WebVTT wrong writing-mode in nested cues
3 participants
@avelad @shaka-bot @theodab