Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gets stuck on lowest bandwidth tracks. #582

Closed
sanbornhilland opened this issue Nov 10, 2016 · 1 comment
Closed

Media gets stuck on lowest bandwidth tracks. #582

sanbornhilland opened this issue Nov 10, 2016 · 1 comment
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@sanbornhilland
Copy link
Contributor

Using latest from master (f7fd3c9)

  1. Loading a live stream we have I can see that occasionally in shaka.abr.SimpleAbrManager.prototype.segmentDownloaded we get a segment with the same endTimeMs and startTimeMs, resulting in a durationMs of 0.
  2. This produces as bandwidth of Infinity in shaka.abr.EwmaBandwidthEstimator.prototype.sample.
  3. When shaka.abr.Ewma.prototype.sample is called with 0 and Infinity it produces an estimate of NaN because: value * (1 - adjAlpha) = Infinity * (1 - 1) = NaN;
  4. this.estimate_ is set to NaN and subsequently every sample after this return NaN

Result:

ABR fails and the media gets stuck on the lowest tracks.

Expected:

Sampling should ignore bad values and move on.

sanbornhilland pushed a commit to sanbornhilland/shaka-player that referenced this issue Nov 10, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 10, 2016
@joeyparrish joeyparrish added this to the v2.1.0 milestone Nov 10, 2016
@joeyparrish
Copy link
Member

Thanks for the report and the PR. Much appreciated!

sanbornhilland pushed a commit to sanbornhilland/shaka-player that referenced this issue Nov 10, 2016
joeyparrish pushed a commit that referenced this issue Nov 16, 2016
This fixes a divide-by-zero that caused the estimate to become NaN.

Fixes #582
joeyparrish pushed a commit that referenced this issue Nov 30, 2016
This fixes a divide-by-zero that caused the estimate to become NaN.

Fixes #582
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants