Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Console Output is Out of Date #653

Closed
jpmedley opened this issue Jan 11, 2017 · 6 comments
Closed

Documentation: Console Output is Out of Date #653

jpmedley opened this issue Jan 11, 2017 · 6 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation

Comments

@jpmedley
Copy link
Contributor

The debugging page purports to show console output from debugging. What's on the page looks nothing like what's in the console.
@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Jan 11, 2017
@joeyparrish
Copy link
Member

Hi Joe, can you please be more specific? What part of that looks wrong to you?

@jpmedley
Copy link
Contributor Author

http_plugin.js:94 HEAD http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mp 404 ()
(anonymous) @ http_plugin.js:94
shaka.net.HttpPlugin @ http_plugin.js:36
shaka.net.NetworkingEngine.send_ @ networking_engine.js:357
(anonymous) @ networking_engine.js:285
string_utils.js:130 Unable to find byte-order-mark, making an educated guess.
http_plugin.js:69 HTTP error text:
http_plugin.js:94 HEAD http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mp 404 ()
(anonymous) @ http_plugin.js:94
shaka.net.HttpPlugin @ http_plugin.js:36
shaka.net.NetworkingEngine.send_ @ networking_engine.js:357
string_utils.js:130 Unable to find byte-order-mark, making an educated guess.
http_plugin.js:69 HTTP error text:

@jpmedley
Copy link
Contributor Author

I also can't seem to get shaka.log.Level to change the output either.

@joeyparrish joeyparrish self-assigned this Jan 20, 2017
@joeyparrish
Copy link
Member

When you copy from the JavaScript console and paste into a text editor, you lose all the formatting and it becomes unreadable. This is why what's in the docs doesn't look exactly like what you pasted.

It looks like there are some updates to make, though. For example, in the tutorial as it is today, we show examples of debug logs before we get to the part about log levels.

@joeyparrish
Copy link
Member

I'll also update the part about log levels to be more explicit about where to insert the call to change the level.

@joeyparrish
Copy link
Member

The tutorial text has been updated. The updates will appear in the nightly build tomorrow, and will be released in v2.0.4 next week.

joeyparrish added a commit that referenced this issue Jan 20, 2017
@joeyparrish
Update the debugging tutorial for clarity
a92685c 
This updates the debugging tutorial to clarify a few things:
 - Formatting in the sample console output is not exact
 - Log level should be set in the top of initApp() before we construct
   the Player object
 - Verbose messages are only seen after we change the log level and
   reload

Closes #653

Change-Id: Id0d7dabff225c3d82a9c54c05bb356a0bfa9b241
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeyparrish @jpmedley @shaka-bot